Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opal 0.7.4 - Fixes & version bump #496

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Opal 0.7.4 - Fixes & version bump #496

merged 2 commits into from
Sep 14, 2023

Conversation

roekatz
Copy link
Collaborator

@roekatz roekatz commented Sep 14, 2023

  • Close web socket on server side when main loop ends.

@roekatz
Bump version to 0.7.4
ac604a2
@roekatz
Pubsub: Explicitly close websocket if main loop ends
c68e0d1 
e.g. - due to broadcaster disconnection
This makes client close connection when broadcaster disconnects, and thus reconenct later and not get into zombie state
@roekatz roekatz requested a review from asafc September 14, 2023 17:49
@netlify
Copy link

netlify bot commented Sep 14, 2023 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit c68e0d1
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/6503479a73d69b0008959f5f

@roekatz roekatz merged commit 8c5c2c2 into master Sep 14, 2023
8 checks passed
@roekatz roekatz deleted the rk/opal-0.7.4 branch September 14, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafc asafc asafc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roekatz @asafc